fix: trailing comma inside delimiters no longer over-indents#27
Merged
Conversation
Two bugs fixed:
1. Trailing commas inside delimited constructs ({}, [], ()) added an
extra indent level because the CONTINUATION regex matched them and
added cx.unit on top of what delimitedIndent already provided. Added
isInsideDelimiter() to skip continuation indent when inside an
unclosed bracket.
2. The CONTINUATION regex's trailing-comment capture (#.*)?$ matched
#{interpolation} inside strings as a "comment", so lines like
"Hello, #{@name}!" were treated as ending with a trailing comma.
Changed to (#(?:[^{].*)?)?$ to exclude #{.
13 new test cases (section 33), 1 previously-skipped test unskipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{},[],()no longer add an extra indent level. AddedisInsideDelimiter()to detect when we're inside an unclosed bracket and skip the continuation indent (sincedelimitedIndentalready handles it).(#.*)?$which was matching#{interpolation}inside strings as a "comment" — e.g."Hello, #{@name}!"was treated as a trailing comma + comment. Changed to(#(?:[^{].*)?)?$.Test plan